2010YOUY01 commented on PR #18468: URL: https://github.com/apache/datafusion/pull/18468#issuecomment-3500982718
> 1. Consolidate the clippy configuration into Cargo.toml (there are a bunch of configs in library functions too -- for example https://github.com/apache/datafusion/blob/7b5685baa7043f8a99ee6613050eeaaa575a50dc/datafusion/common/src/lib.rs#L23-L25 I got that part wrong, turns out they're staying in `lib.rs` for good reasons. We're not able to inherit workspace global lint, and do linter rule overrides in sub-crates in `Cargo.toml`, this feature is not supported yet https://github.com/rust-lang/cargo/issues/13157, so we have to do that in `lib.rs` Thanks @Jefffrey for catching it when reviewing https://github.com/apache/datafusion/pull/18520 I have fixed it here in [f6c873c](https://github.com/apache/datafusion/pull/18468/commits/f6c873ca2d9dc2c03b26211e378221c8c166b8c1) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
