petern48 commented on code in PR #18637:
URL: https://github.com/apache/datafusion/pull/18637#discussion_r2516340516
##########
.github/workflows/take.yml:
##########
@@ -26,16 +26,30 @@ permissions:
jobs:
issue_assign:
runs-on: ubuntu-latest
- if: (!github.event.issue.pull_request) && github.event.comment.body ==
'take'
+ if: (!github.event.issue.pull_request) && (github.event.comment.body ==
'take' || github.event.comment.body == 'untake')
concurrency:
group: ${{ github.actor }}-issue-assign
steps:
- - run: |
- CODE=$(curl -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}"
-LI https://api.github.com/repos/${{ github.repository }}/issues/${{
github.event.issue.number }}/assignees/${{ github.event.comment.user.login }}
-o /dev/null -w '%{http_code}\n' -s)
- if [ "$CODE" -eq "204" ]
+ - name: Take or untake issue
+ run: |
+ COMMENT_BODY="${{ github.event.comment.body }}"
Review Comment:
I'm just now seeing that second comment after reloading the page... Eh I
think it's fine to require 'take' / 'untake' exactly without extra whitespace.
I can add it if someone feels strongly about it, but it wasn't in place before
this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
