martin-g commented on code in PR #18637:
URL: https://github.com/apache/datafusion/pull/18637#discussion_r2517597076
##########
docs/source/contributor-guide/index.md:
##########
@@ -59,9 +59,8 @@ If you want to work on an issue which is not already assigned
to someone else
and there are no comment indicating that someone is already working on that
issue then you can assign the issue to yourself by submitting a single word
comment `take`. This will assign the issue to yourself. However, if you are
-unable to make progress you should unassign the issue by using the `unassign
me`
-link at the top of the issue page (and ask for help if are stuck) so that
-someone else can get involved in the work.
+unable to make progress you should unassign the issue by commenting a single
+work `untake`.
Review Comment:
```suggestion
word `untake`.
```
##########
.github/workflows/take.yml:
##########
@@ -26,16 +26,30 @@ permissions:
jobs:
issue_assign:
runs-on: ubuntu-latest
- if: (!github.event.issue.pull_request) && github.event.comment.body ==
'take'
+ if: (!github.event.issue.pull_request) && (github.event.comment.body ==
'take' || github.event.comment.body == 'untake')
concurrency:
group: ${{ github.actor }}-issue-assign
steps:
- - run: |
- CODE=$(curl -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}"
-LI https://api.github.com/repos/${{ github.repository }}/issues/${{
github.event.issue.number }}/assignees/${{ github.event.comment.user.login }}
-o /dev/null -w '%{http_code}\n' -s)
- if [ "$CODE" -eq "204" ]
+ - name: Take or untake issue
+ env:
+ COMMENT_BODY: ${{ github.event.comment.body }}
+ ISSUE_NUMBER: ${{ github.event.issue.number }}
+ USER_LOGIN: ${{ github.event.comment.user.login }}
+ REPO: ${{ github.repository }}
+ TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ run: |
+ if [ "$COMMENT_BODY" == "take" ]
then
- echo "Assigning issue ${{ github.event.issue.number }} to ${{
github.event.comment.user.login }}"
- curl -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" -d
'{"assignees": ["${{ github.event.comment.user.login }}"]}'
https://api.github.com/repos/${{ github.repository }}/issues/${{
github.event.issue.number }}/assignees
- else
- echo "Cannot assign issue ${{ github.event.issue.number }} to ${{
github.event.comment.user.login }}"
+ CODE=$(curl -H "Authorization: token $TOKEN" -LI
https://api.github.com/repos/$REPO/issues/$ISSUE_NUMBER/assignees/$USER_LOGIN
-o /dev/null -w '%{http_code}\n' -s)
+ if [ "$CODE" -eq "204" ]
Review Comment:
Since you compare strings IMO it would be better to use `=` (or Bash's `==`)
here. If $CODE for any reason is not an integer now it will fail with (cryptic)
`integer expression expected` rather than echoing "Cannot assign ..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
