coracuity commented on code in PR #18637:
URL: https://github.com/apache/datafusion/pull/18637#discussion_r2516410118


##########
.github/workflows/take.yml:
##########
@@ -26,16 +26,30 @@ permissions:
 jobs:
   issue_assign:
     runs-on: ubuntu-latest
-    if: (!github.event.issue.pull_request) && github.event.comment.body == 
'take'
+    if: (!github.event.issue.pull_request) && (github.event.comment.body == 
'take' || github.event.comment.body == 'untake')
     concurrency:
       group: ${{ github.actor }}-issue-assign
     steps:
-      - run: |
-          CODE=$(curl -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" 
-LI https://api.github.com/repos/${{ github.repository }}/issues/${{ 
github.event.issue.number }}/assignees/${{ github.event.comment.user.login }} 
-o /dev/null -w '%{http_code}\n' -s)
-          if [ "$CODE" -eq "204" ]
+      - name: Take or untake issue
+        env:
+          COMMENT_BODY: ${{ github.event.comment.body }}
+          ISSUE_NUMBER: ${{ github.event.issue.number }}
+          USER_LOGIN: ${{ github.event.comment.user.login }}
+          REPO: ${{ github.repository }}
+          TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          if [ "$COMMENT_BODY" == "take" ]
           then
-            echo "Assigning issue ${{ github.event.issue.number }} to ${{ 
github.event.comment.user.login }}"
-            curl -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" -d 
'{"assignees": ["${{ github.event.comment.user.login }}"]}' 
https://api.github.com/repos/${{ github.repository }}/issues/${{ 
github.event.issue.number }}/assignees
-          else
-            echo "Cannot assign issue ${{ github.event.issue.number }} to ${{ 
github.event.comment.user.login }}"
+            CODE=$(curl -H "Authorization: token $TOKEN" -LI 
https://api.github.com/repos/$REPO/issues/$ISSUE_NUMBER/assignees/$USER_LOGIN 
-o /dev/null -w '%{http_code}\n' -s)

Review Comment:
   TIL that GH's REST API allows HEAD for GET requests, neat!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to