martin-g commented on code in PR #18630:
URL: https://github.com/apache/datafusion/pull/18630#discussion_r2518217044
##########
datafusion/sqllogictest/test_files/options.slt:
##########
Review Comment:
This comment needs to be updated since there is no `coalesce` anymore
##########
datafusion/sqllogictest/test_files/cte.slt:
##########
@@ -162,10 +161,9 @@ physical_plan
03)----DataSourceExec: file_groups={1 group:
[[WORKSPACE_ROOT/datafusion/core/tests/data/recursive_cte/balance.csv]]},
projection=[time, name, account_balance], file_type=csv, has_header=true
04)----CoalescePartitionsExec
05)------ProjectionExec: expr=[time@0 + 1 as time, name@1 as name,
account_balance@2 + 10 as account_balance]
-06)--------CoalesceBatchesExec: target_batch_size=2
Review Comment:
Should the setting and the comment at
https://github.com/apache/datafusion/pull/18630/files#diff-e1670149161d1c460b42c462b84e85ace538b079a964aea5cd5930f9a025c894R134-R138
be updated now ? Is `set datafusion.execution.batch_size = 2;` still in play
now ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
