Dandandan commented on code in PR #18630:
URL: https://github.com/apache/datafusion/pull/18630#discussion_r2523114189
##########
datafusion/sqllogictest/test_files/cte.slt:
##########
@@ -162,10 +161,9 @@ physical_plan
03)----DataSourceExec: file_groups={1 group:
[[WORKSPACE_ROOT/datafusion/core/tests/data/recursive_cte/balance.csv]]},
projection=[time, name, account_balance], file_type=csv, has_header=true
04)----CoalescePartitionsExec
05)------ProjectionExec: expr=[time@0 + 1 as time, name@1 as name,
account_balance@2 + 10 as account_balance]
-06)--------CoalesceBatchesExec: target_batch_size=2
-07)----------FilterExec: time@0 < 10
-08)------------RepartitionExec: partitioning=RoundRobinBatch(4),
input_partitions=1
-09)--------------WorkTableExec: name=balances
+06)--------FilterExec: time@0 < 10
Review Comment:
IMO it's a bit too much to add `batch_size` to the plan everywhere (as it's
a query-wide thing)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
