Dandandan commented on code in PR #18630:
URL: https://github.com/apache/datafusion/pull/18630#discussion_r2527116293
##########
datafusion/physical-plan/src/filter.rs:
##########
@@ -729,11 +777,11 @@ impl Stream for FilterExecStream {
}).and_then(|(array, batch)| {
match as_boolean_array(&array) {
Ok(filter_array) => {
-
self.metrics.selectivity.add_part(filter_array.true_count());
self.metrics.selectivity.add_total(batch.num_rows());
-
-
self.batch_coalescer.push_batch_with_filter(batch.clone(), filter_array)?;
- Ok(())
+ // TODO: support push_batch_with_filter in
LimitedBatchCoalescer
Review Comment:
Thanks, that would be nice
##########
datafusion/physical-plan/src/filter.rs:
##########
@@ -409,8 +423,11 @@ impl ExecutionPlan for FilterExec {
input: self.input.execute(partition, context)?,
metrics,
projection: self.projection.clone(),
- batch_coalescer: BatchCoalescer::new(self.schema(),
self.batch_size)
- .with_biggest_coalesce_batch_size(Some(self.batch_size / 2)),
+ batch_coalescer: LimitedBatchCoalescer::new(
+ self.schema(),
Review Comment:
Yeah, agreed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
