rluvaton commented on code in PR #18820:
URL: https://github.com/apache/datafusion/pull/18820#discussion_r2564201623
##########
datafusion/datasource-parquet/src/opener.rs:
##########
@@ -87,6 +89,8 @@ pub(super) struct ParquetOpener {
pub pushdown_filters: bool,
/// Should the filters be reordered to optimize the scan?
pub reorder_filters: bool,
+ /// Should we force the reader to use RowSelections for filtering
+ pub force_filter_selections: bool,
Review Comment:
What do you think of making it an enum instead to allow for future additions
without breaking changes?
(that enum should also be non exhaustive to avoid adding a variant a
breaking change)
I also see that the `with_row_selection_policy` already accept enum.
making it an enum also allow to force mask or configure the threshold in the
auto policy. this is also useful for testing to force specific path when
creating a reproduction test for a bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
