rluvaton commented on code in PR #18820: URL: https://github.com/apache/datafusion/pull/18820#discussion_r2564139869
########## datafusion/sqllogictest/test_files/array.slt: ########## @@ -1978,11 +1978,11 @@ select array_slice(arrow_cast(make_array(1, 2, 3, 4, 5), 'LargeList(Int64)'), 0, ---- [1, 2, 3, 4, 5] [h, e, l, l, o] -# TODO: Enable once arrow_cast supports ListView types. +# TODO: Enable once array_slice supports LargeListView types. Review Comment: It seems like you copy pasted from below, but this test `ListView` and not `LargeListView` ```suggestion # TODO: Enable once array_slice supports ListView types. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
