zhuqi-lucas commented on code in PR #18817:
URL: https://github.com/apache/datafusion/pull/18817#discussion_r2569303471
##########
datafusion/physical-optimizer/src/optimizer.rs:
##########
@@ -145,11 +146,9 @@ impl PhysicalOptimizer {
// are not present, the load of executors such as join or union
will be
// reduced by narrowing their input tables.
Arc::new(ProjectionPushdown::new()),
- Arc::new(EnsureCooperative::new()),
- // This FilterPushdown handles dynamic filters that may have
references to the source ExecutionPlan.
- // Therefore it should be run at the end of the optimization
process since any changes to the plan may break the dynamic filter's references.
- // See `FilterPushdownPhase` for more details.
- Arc::new(FilterPushdown::new_post_optimization()),
+ // ReverseOrder: Detect DESC sorts that can use reverse scan
+ // This marks reverse_scan=true on DataSourceExec
+ Arc::new(PushdownSort::new()),
// The SanityCheckPlan rule checks whether the order and
Review Comment:
Thank you @alamb for good catch, i addressed this in latest PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
