zhuqi-lucas commented on PR #18817: URL: https://github.com/apache/datafusion/pull/18817#issuecomment-3586500768
> This is super impressive @zhuqi-lucas 🙏 I started going through it but wasn't able to finish before I ran out of time. I still need to review the code in `opener.rs` but I left the comments I have so far > > 1. Do you have any performance results with this optimization (in other words, do we have some benchmarks to show the improvement that comes with the complexity?) > > While this PR was quite easy to review (nice work!), I do think we should break it into parts to make it easier for others to comment on. Specifically, the > > * PushdownSort optimization and API for sorts in the scan (I think @adriangb was thinking about this too recently) Thank you @alamb for review, i agree we can split to more PRs, and the performance test still needed as follow-up, and we may first make the default flag false for this feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
