Jefffrey commented on code in PR #19043:
URL: https://github.com/apache/datafusion/pull/19043#discussion_r2580596595
##########
datafusion/physical-plan/src/filter.rs:
##########
@@ -690,6 +690,8 @@ struct FilterExecMetrics {
baseline_metrics: BaselineMetrics,
// Selectivity of the filter, calculated as output_rows / input_rows
selectivity: RatioMetrics,
+ // Remember to update `docs/source/user-guide/metrics.md` when adding new
metrics
+ // , or modifying metrics comments
Review Comment:
```suggestion
// Remember to update `docs/source/user-guide/metrics.md` when adding
new metrics,
// or modifying metrics comments
```
We'd have to add these comments to all metric structs? Is there a way we can
take a macro based approach, similar to UDFs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
