2010YOUY01 commented on code in PR #19043:
URL: https://github.com/apache/datafusion/pull/19043#discussion_r2580629463
##########
datafusion/physical-plan/src/filter.rs:
##########
@@ -690,6 +690,8 @@ struct FilterExecMetrics {
baseline_metrics: BaselineMetrics,
// Selectivity of the filter, calculated as output_rows / input_rows
selectivity: RatioMetrics,
+ // Remember to update `docs/source/user-guide/metrics.md` when adding new
metrics
+ // , or modifying metrics comments
Review Comment:
I have thought about it, but this approach is difficult and might even be
more complex.
Unlike functions (they're all inside the function registry and we can
iterate through them), metrics are registered on the fly during executing, and
the place to register them are scattered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
