martin-g commented on code in PR #19043:
URL: https://github.com/apache/datafusion/pull/19043#discussion_r2581286772
##########
datafusion/physical-plan/src/filter.rs:
##########
Review Comment:
Not directly related to this PR but I see no reason why comments are being
used here instead of docstrings. It is a private struct but the same is valid
for `FilterExecStream`
```suggestion
/// Common metrics for most operators
```
##########
datafusion/physical-plan/src/filter.rs:
##########
@@ -690,6 +690,8 @@ struct FilterExecMetrics {
baseline_metrics: BaselineMetrics,
// Selectivity of the filter, calculated as output_rows / input_rows
Review Comment:
```suggestion
/// Selectivity of the filter, calculated as output_rows / input_rows
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
