sdf-jkl commented on PR #18789: URL: https://github.com/apache/datafusion/pull/18789#issuecomment-3602487810
> Thank you again for pushing it forward! @sdf-jkl > > To make the PRs easier to review, we typically want them to be small and focused, rather than being comprehensive. > > I suggest we can > > 1. Update the PR writeup for the idea to implement (I think it's this one? [Support "pre-image" for pruning predicate evaluation #18789 (comment)](https://github.com/apache/datafusion/pull/18789#discussion_r2561194219)) > 2. List the applicable cases in the writeup (like this one [ab9b444](https://github.com/apache/datafusion/pull/18789/commits/ab9b444edce669583654589be48841746abb6359) and others) > 3. In the initial PR only include the simplest applicable case, for example year extraction re-writing. > > And we can iterate faster for this PR, and add other similar optimizations in the future. @2010YOUY01 Thanks for the heads up, this makes sense. I will work on adding the sqllogictests to push this PR forward and create separate issues for other improvements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
