sdf-jkl commented on PR #18789: URL: https://github.com/apache/datafusion/pull/18789#issuecomment-3603745382
@alamb @2010YOUY01 I updated sqllogictests to include these changes: The tests check: - Simple optimization where col in LHS of the comparison - Check that date_part is out of the explain statements for the same queries - Simple optimizations, but col in RHS - Check that different interval types for date_part are not optimized - Check simple optimizations for different datatypes - Check explain statements for the different datatype queries above The tests do not check: - NULL as the literal to compare to in the expression (null is not currently supported for this optimization) - Full null-handling cases for `is distinct from`/`is not distinct from` due to missing tests above - Edge cases? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
