Jefffrey commented on code in PR #19592: URL: https://github.com/apache/datafusion/pull/19592#discussion_r2656435446
########## datafusion/spark/src/function/collection/size.rs: ########## @@ -0,0 +1,349 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use arrow::array::{ + Array, ArrayRef, AsArray, FixedSizeListArray, Int32Array, Int32Builder, +}; +use arrow::datatypes::{DataType, Field, FieldRef}; +use datafusion_common::{Result, plan_err}; +use datafusion_expr::{ + ColumnarValue, ReturnFieldArgs, ScalarFunctionArgs, ScalarUDFImpl, Signature, + TypeSignature, Volatility, +}; +use datafusion_functions::utils::make_scalar_function; +use std::any::Any; +use std::sync::Arc; + +/// Spark-compatible `size` function. +/// +/// Returns the number of elements in an array or the number of key-value pairs in a map. +/// Returns null for null input. +#[derive(Debug, PartialEq, Eq, Hash)] +pub struct SparkSize { + signature: Signature, +} + +impl Default for SparkSize { + fn default() -> Self { + Self::new() + } +} + +impl SparkSize { + pub fn new() -> Self { + Self { + signature: Signature::one_of( + vec![TypeSignature::Any(1)], Review Comment: This type signature is too wide; I recommend exploring the signature API we provide and related functions to implement a more strict signature ########## datafusion/spark/src/function/collection/size.rs: ########## @@ -0,0 +1,349 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use arrow::array::{ + Array, ArrayRef, AsArray, FixedSizeListArray, Int32Array, Int32Builder, +}; +use arrow::datatypes::{DataType, Field, FieldRef}; +use datafusion_common::{Result, plan_err}; +use datafusion_expr::{ + ColumnarValue, ReturnFieldArgs, ScalarFunctionArgs, ScalarUDFImpl, Signature, + TypeSignature, Volatility, +}; +use datafusion_functions::utils::make_scalar_function; +use std::any::Any; +use std::sync::Arc; + +/// Spark-compatible `size` function. +/// +/// Returns the number of elements in an array or the number of key-value pairs in a map. +/// Returns null for null input. +#[derive(Debug, PartialEq, Eq, Hash)] +pub struct SparkSize { + signature: Signature, +} + +impl Default for SparkSize { + fn default() -> Self { + Self::new() + } +} + +impl SparkSize { + pub fn new() -> Self { + Self { + signature: Signature::one_of( + vec![TypeSignature::Any(1)], + Volatility::Immutable, + ), + } + } +} + +impl ScalarUDFImpl for SparkSize { + fn as_any(&self) -> &dyn Any { + self + } + + fn name(&self) -> &str { + "size" + } + + fn signature(&self) -> &Signature { + &self.signature + } + + fn return_type(&self, _arg_types: &[DataType]) -> Result<DataType> { + Ok(DataType::Int32) + } + + fn return_field_from_args(&self, args: ReturnFieldArgs) -> Result<FieldRef> { + if args.arg_fields.len() != 1 { + return plan_err!("size expects exactly 1 argument"); + } + + let input_field = &args.arg_fields[0]; + + match input_field.data_type() { + DataType::List(_) + | DataType::LargeList(_) + | DataType::FixedSizeList(_, _) + | DataType::Map(_, _) + | DataType::Null => {} + dt => { + return plan_err!( + "size function requires array or map types, got: {}", + dt + ); + } + } + + let mut out_nullable = input_field.is_nullable(); + + let scala_null_present = args + .scalar_arguments + .iter() + .any(|opt_s| opt_s.is_some_and(|sv| sv.is_null())); + if scala_null_present { + out_nullable = true; + } + + Ok(Arc::new(Field::new( + self.name(), + DataType::Int32, + out_nullable, + ))) + } + + fn invoke_with_args(&self, args: ScalarFunctionArgs) -> Result<ColumnarValue> { + if args.args.len() != 1 { + return plan_err!("size expects exactly 1 argument"); + } + make_scalar_function(spark_size_inner, vec![])(&args.args) + } +} + +fn spark_size_inner(args: &[ArrayRef]) -> Result<ArrayRef> { + let array = &args[0]; + + match array.data_type() { + DataType::List(_) => { + let list_array = array.as_list::<i32>(); + let mut builder = Int32Builder::with_capacity(list_array.len()); + for i in 0..list_array.len() { + if list_array.is_null(i) { + builder.append_null(); + } else { + let len = list_array.value(i).len(); + builder.append_value(len as i32) + } + } + + Ok(Arc::new(builder.finish())) Review Comment: I feel we can greatly simplify this if we use a unary kernel instead of a separate builder 🤔 Or even utilize the `OffsetBuffer` inside to grab the lengths, e.g. https://docs.rs/arrow/latest/arrow/buffer/struct.OffsetBuffer.html#method.lengths ########## datafusion/spark/src/function/collection/size.rs: ########## @@ -0,0 +1,349 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use arrow::array::{ + Array, ArrayRef, AsArray, FixedSizeListArray, Int32Array, Int32Builder, +}; +use arrow::datatypes::{DataType, Field, FieldRef}; +use datafusion_common::{Result, plan_err}; +use datafusion_expr::{ + ColumnarValue, ReturnFieldArgs, ScalarFunctionArgs, ScalarUDFImpl, Signature, + TypeSignature, Volatility, +}; +use datafusion_functions::utils::make_scalar_function; +use std::any::Any; +use std::sync::Arc; + +/// Spark-compatible `size` function. +/// +/// Returns the number of elements in an array or the number of key-value pairs in a map. +/// Returns null for null input. +#[derive(Debug, PartialEq, Eq, Hash)] +pub struct SparkSize { + signature: Signature, +} + +impl Default for SparkSize { + fn default() -> Self { + Self::new() + } +} + +impl SparkSize { + pub fn new() -> Self { + Self { + signature: Signature::one_of( + vec![TypeSignature::Any(1)], + Volatility::Immutable, + ), + } + } +} + +impl ScalarUDFImpl for SparkSize { + fn as_any(&self) -> &dyn Any { + self + } + + fn name(&self) -> &str { + "size" + } + + fn signature(&self) -> &Signature { + &self.signature + } + + fn return_type(&self, _arg_types: &[DataType]) -> Result<DataType> { + Ok(DataType::Int32) + } + + fn return_field_from_args(&self, args: ReturnFieldArgs) -> Result<FieldRef> { + if args.arg_fields.len() != 1 { + return plan_err!("size expects exactly 1 argument"); + } + + let input_field = &args.arg_fields[0]; + + match input_field.data_type() { + DataType::List(_) + | DataType::LargeList(_) + | DataType::FixedSizeList(_, _) + | DataType::Map(_, _) + | DataType::Null => {} + dt => { + return plan_err!( + "size function requires array or map types, got: {}", + dt + ); + } + } + + let mut out_nullable = input_field.is_nullable(); + + let scala_null_present = args + .scalar_arguments + .iter() + .any(|opt_s| opt_s.is_some_and(|sv| sv.is_null())); + if scala_null_present { + out_nullable = true; + } + + Ok(Arc::new(Field::new( + self.name(), + DataType::Int32, + out_nullable, + ))) + } + + fn invoke_with_args(&self, args: ScalarFunctionArgs) -> Result<ColumnarValue> { + if args.args.len() != 1 { + return plan_err!("size expects exactly 1 argument"); + } Review Comment: ```suggestion ``` Signature guards us ########## datafusion/spark/src/function/collection/size.rs: ########## @@ -0,0 +1,349 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use arrow::array::{ + Array, ArrayRef, AsArray, FixedSizeListArray, Int32Array, Int32Builder, +}; +use arrow::datatypes::{DataType, Field, FieldRef}; +use datafusion_common::{Result, plan_err}; +use datafusion_expr::{ + ColumnarValue, ReturnFieldArgs, ScalarFunctionArgs, ScalarUDFImpl, Signature, + TypeSignature, Volatility, +}; +use datafusion_functions::utils::make_scalar_function; +use std::any::Any; +use std::sync::Arc; + +/// Spark-compatible `size` function. +/// +/// Returns the number of elements in an array or the number of key-value pairs in a map. +/// Returns null for null input. +#[derive(Debug, PartialEq, Eq, Hash)] +pub struct SparkSize { + signature: Signature, +} + +impl Default for SparkSize { + fn default() -> Self { + Self::new() + } +} + +impl SparkSize { + pub fn new() -> Self { + Self { + signature: Signature::one_of( + vec![TypeSignature::Any(1)], + Volatility::Immutable, + ), + } + } +} + +impl ScalarUDFImpl for SparkSize { + fn as_any(&self) -> &dyn Any { + self + } + + fn name(&self) -> &str { + "size" + } + + fn signature(&self) -> &Signature { + &self.signature + } + + fn return_type(&self, _arg_types: &[DataType]) -> Result<DataType> { + Ok(DataType::Int32) + } + + fn return_field_from_args(&self, args: ReturnFieldArgs) -> Result<FieldRef> { + if args.arg_fields.len() != 1 { + return plan_err!("size expects exactly 1 argument"); + } + + let input_field = &args.arg_fields[0]; + + match input_field.data_type() { + DataType::List(_) + | DataType::LargeList(_) + | DataType::FixedSizeList(_, _) + | DataType::Map(_, _) + | DataType::Null => {} + dt => { + return plan_err!( + "size function requires array or map types, got: {}", + dt + ); + } + } + + let mut out_nullable = input_field.is_nullable(); + + let scala_null_present = args + .scalar_arguments + .iter() + .any(|opt_s| opt_s.is_some_and(|sv| sv.is_null())); + if scala_null_present { + out_nullable = true; + } + + Ok(Arc::new(Field::new( + self.name(), + DataType::Int32, + out_nullable, + ))) Review Comment: ```suggestion Ok(Arc::new(Field::new( self.name(), DataType::Int32, args.arg_fields[0].is_nullable(), ))) ``` - We don't need to check argument count; signature guards this for us - If we had a stricter signature then we wouldn't need to check input types either - It's redundant to check for scalar nulls because if the input had a scalar null then the field would already be nullable ########## datafusion/spark/src/function/collection/size.rs: ########## @@ -0,0 +1,349 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use arrow::array::{ + Array, ArrayRef, AsArray, FixedSizeListArray, Int32Array, Int32Builder, +}; +use arrow::datatypes::{DataType, Field, FieldRef}; +use datafusion_common::{Result, plan_err}; +use datafusion_expr::{ + ColumnarValue, ReturnFieldArgs, ScalarFunctionArgs, ScalarUDFImpl, Signature, + TypeSignature, Volatility, +}; +use datafusion_functions::utils::make_scalar_function; +use std::any::Any; +use std::sync::Arc; + +/// Spark-compatible `size` function. +/// +/// Returns the number of elements in an array or the number of key-value pairs in a map. +/// Returns null for null input. +#[derive(Debug, PartialEq, Eq, Hash)] +pub struct SparkSize { + signature: Signature, +} + +impl Default for SparkSize { + fn default() -> Self { + Self::new() + } +} + +impl SparkSize { + pub fn new() -> Self { + Self { + signature: Signature::one_of( + vec![TypeSignature::Any(1)], + Volatility::Immutable, + ), + } + } +} + +impl ScalarUDFImpl for SparkSize { + fn as_any(&self) -> &dyn Any { + self + } + + fn name(&self) -> &str { + "size" + } + + fn signature(&self) -> &Signature { + &self.signature + } + + fn return_type(&self, _arg_types: &[DataType]) -> Result<DataType> { + Ok(DataType::Int32) + } + + fn return_field_from_args(&self, args: ReturnFieldArgs) -> Result<FieldRef> { + if args.arg_fields.len() != 1 { + return plan_err!("size expects exactly 1 argument"); + } + + let input_field = &args.arg_fields[0]; + + match input_field.data_type() { + DataType::List(_) + | DataType::LargeList(_) + | DataType::FixedSizeList(_, _) + | DataType::Map(_, _) + | DataType::Null => {} + dt => { + return plan_err!( + "size function requires array or map types, got: {}", + dt + ); + } + } + + let mut out_nullable = input_field.is_nullable(); + + let scala_null_present = args + .scalar_arguments + .iter() + .any(|opt_s| opt_s.is_some_and(|sv| sv.is_null())); + if scala_null_present { + out_nullable = true; + } + + Ok(Arc::new(Field::new( + self.name(), + DataType::Int32, + out_nullable, + ))) + } + + fn invoke_with_args(&self, args: ScalarFunctionArgs) -> Result<ColumnarValue> { + if args.args.len() != 1 { + return plan_err!("size expects exactly 1 argument"); + } + make_scalar_function(spark_size_inner, vec![])(&args.args) + } +} + +fn spark_size_inner(args: &[ArrayRef]) -> Result<ArrayRef> { + let array = &args[0]; + + match array.data_type() { + DataType::List(_) => { + let list_array = array.as_list::<i32>(); + let mut builder = Int32Builder::with_capacity(list_array.len()); + for i in 0..list_array.len() { + if list_array.is_null(i) { + builder.append_null(); + } else { + let len = list_array.value(i).len(); + builder.append_value(len as i32) + } + } + + Ok(Arc::new(builder.finish())) + } + DataType::LargeList(_) => { + let list_array = array.as_list::<i64>(); + let mut builder = Int32Builder::with_capacity(list_array.len()); + for i in 0..list_array.len() { + if list_array.is_null(i) { + builder.append_null(); + } else { + let len = list_array.value(i).len(); + builder.append_value(len as i32) + } + } + + Ok(Arc::new(builder.finish())) + } + DataType::FixedSizeList(_, size) => { + let list_array: &FixedSizeListArray = array.as_fixed_size_list(); + let fixed_size = *size; + let result: Int32Array = (0..list_array.len()) + .map(|i| { + if list_array.is_null(i) { + None + } else { + Some(fixed_size) + } + }) + .collect(); + + Ok(Arc::new(result)) + } + DataType::Map(_, _) => { + let map_array = array.as_map(); + let mut builder = Int32Builder::with_capacity(map_array.len()); + + for i in 0..map_array.len() { + if map_array.is_null(i) { + builder.append_null(); + } else { + let len = map_array.value(i).len(); + builder.append_value(len as i32) + } + } + + Ok(Arc::new(builder.finish())) + } + DataType::Null => Ok(Arc::new(Int32Array::new_null(array.len()))), + dt => { + plan_err!("size function does not support type: {}", dt) + } + } +} + +#[cfg(test)] +mod tests { + use super::*; + use arrow::array::{Int32Array, ListArray, MapArray, StringArray, StructArray}; + use arrow::buffer::{NullBuffer, OffsetBuffer}; + use arrow::datatypes::{DataType, Field, Fields}; + use datafusion_common::ScalarValue; + use datafusion_expr::ReturnFieldArgs; + + #[test] + fn test_size_nullability() { + let size_fn = SparkSize::new(); + + // Non-nullable list input -> non-nullable output + let non_nullable_list = Arc::new(Field::new( + "col", Review Comment: Personally I'd remove this test; the amount of code it requires doesn't really justify the value I see it bringing 🤔 ########## datafusion/spark/src/function/collection/size.rs: ########## @@ -0,0 +1,349 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use arrow::array::{ + Array, ArrayRef, AsArray, FixedSizeListArray, Int32Array, Int32Builder, +}; +use arrow::datatypes::{DataType, Field, FieldRef}; +use datafusion_common::{Result, plan_err}; +use datafusion_expr::{ + ColumnarValue, ReturnFieldArgs, ScalarFunctionArgs, ScalarUDFImpl, Signature, + TypeSignature, Volatility, +}; +use datafusion_functions::utils::make_scalar_function; +use std::any::Any; +use std::sync::Arc; + +/// Spark-compatible `size` function. +/// +/// Returns the number of elements in an array or the number of key-value pairs in a map. +/// Returns null for null input. +#[derive(Debug, PartialEq, Eq, Hash)] +pub struct SparkSize { + signature: Signature, +} + +impl Default for SparkSize { + fn default() -> Self { + Self::new() + } +} + +impl SparkSize { + pub fn new() -> Self { + Self { + signature: Signature::one_of( + vec![TypeSignature::Any(1)], + Volatility::Immutable, + ), + } + } +} + +impl ScalarUDFImpl for SparkSize { + fn as_any(&self) -> &dyn Any { + self + } + + fn name(&self) -> &str { + "size" + } + + fn signature(&self) -> &Signature { + &self.signature + } + + fn return_type(&self, _arg_types: &[DataType]) -> Result<DataType> { + Ok(DataType::Int32) + } + + fn return_field_from_args(&self, args: ReturnFieldArgs) -> Result<FieldRef> { + if args.arg_fields.len() != 1 { + return plan_err!("size expects exactly 1 argument"); + } + + let input_field = &args.arg_fields[0]; + + match input_field.data_type() { + DataType::List(_) + | DataType::LargeList(_) + | DataType::FixedSizeList(_, _) + | DataType::Map(_, _) + | DataType::Null => {} + dt => { + return plan_err!( + "size function requires array or map types, got: {}", + dt + ); + } + } + + let mut out_nullable = input_field.is_nullable(); + + let scala_null_present = args + .scalar_arguments + .iter() + .any(|opt_s| opt_s.is_some_and(|sv| sv.is_null())); + if scala_null_present { + out_nullable = true; + } + + Ok(Arc::new(Field::new( + self.name(), + DataType::Int32, + out_nullable, + ))) + } + + fn invoke_with_args(&self, args: ScalarFunctionArgs) -> Result<ColumnarValue> { + if args.args.len() != 1 { + return plan_err!("size expects exactly 1 argument"); + } + make_scalar_function(spark_size_inner, vec![])(&args.args) + } +} + +fn spark_size_inner(args: &[ArrayRef]) -> Result<ArrayRef> { + let array = &args[0]; + + match array.data_type() { + DataType::List(_) => { + let list_array = array.as_list::<i32>(); + let mut builder = Int32Builder::with_capacity(list_array.len()); + for i in 0..list_array.len() { + if list_array.is_null(i) { + builder.append_null(); + } else { + let len = list_array.value(i).len(); + builder.append_value(len as i32) + } + } + + Ok(Arc::new(builder.finish())) + } + DataType::LargeList(_) => { + let list_array = array.as_list::<i64>(); + let mut builder = Int32Builder::with_capacity(list_array.len()); + for i in 0..list_array.len() { + if list_array.is_null(i) { + builder.append_null(); + } else { + let len = list_array.value(i).len(); + builder.append_value(len as i32) + } + } + + Ok(Arc::new(builder.finish())) + } + DataType::FixedSizeList(_, size) => { + let list_array: &FixedSizeListArray = array.as_fixed_size_list(); + let fixed_size = *size; + let result: Int32Array = (0..list_array.len()) + .map(|i| { + if list_array.is_null(i) { + None + } else { + Some(fixed_size) + } + }) + .collect(); + + Ok(Arc::new(result)) + } + DataType::Map(_, _) => { + let map_array = array.as_map(); + let mut builder = Int32Builder::with_capacity(map_array.len()); + + for i in 0..map_array.len() { + if map_array.is_null(i) { + builder.append_null(); + } else { + let len = map_array.value(i).len(); + builder.append_value(len as i32) + } + } + + Ok(Arc::new(builder.finish())) + } + DataType::Null => Ok(Arc::new(Int32Array::new_null(array.len()))), + dt => { + plan_err!("size function does not support type: {}", dt) + } + } +} + +#[cfg(test)] +mod tests { + use super::*; + use arrow::array::{Int32Array, ListArray, MapArray, StringArray, StructArray}; + use arrow::buffer::{NullBuffer, OffsetBuffer}; + use arrow::datatypes::{DataType, Field, Fields}; + use datafusion_common::ScalarValue; + use datafusion_expr::ReturnFieldArgs; + + #[test] + fn test_size_nullability() { + let size_fn = SparkSize::new(); + + // Non-nullable list input -> non-nullable output + let non_nullable_list = Arc::new(Field::new( + "col", + DataType::List(Arc::new(Field::new("item", DataType::Int32, true))), + false, + )); + let out = size_fn + .return_field_from_args(ReturnFieldArgs { + arg_fields: &[Arc::clone(&non_nullable_list)], + scalar_arguments: &[None], + }) + .unwrap(); + + assert!(!out.is_nullable()); + assert_eq!(out.data_type(), &DataType::Int32); + + // Nullable list output -> nullable output + let nullable_list = Arc::new(Field::new( + "col", + DataType::List(Arc::new(Field::new("item", DataType::Int32, true))), + true, + )); + let out = size_fn + .return_field_from_args(ReturnFieldArgs { + arg_fields: &[Arc::clone(&nullable_list)], + scalar_arguments: &[None], + }) + .unwrap(); + + assert!(out.is_nullable()); + } + + #[test] + fn test_size_with_null_scalar() { + let size_fn = SparkSize::new(); + + let non_nullable_list = Arc::new(Field::new( + "col", + DataType::List(Arc::new(Field::new("item", DataType::Int32, true))), + false, + )); + + // With null scalar argument Review Comment: These tests onwards should be moved to SLTs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
