CuteChuanChuan commented on code in PR #19592: URL: https://github.com/apache/datafusion/pull/19592#discussion_r2682265757
########## datafusion/sqllogictest/test_files/spark/collection/size.slt: ########## @@ -0,0 +1,129 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at + +# http://www.apache.org/licenses/LICENSE-2.0 + +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# This file was originally created by a porting script from: +# https://github.com/lakehq/sail/tree/43b6ed8221de5c4c4adbedbb267ae1351158b43c/crates/sail-spark-connect/tests/gold_data/function +# This file is part of the implementation of the datafusion-spark function library. +# For more information, please see: +# https://github.com/apache/datafusion/issues/15914 + +## Original Query: SELECT size(array(1, 2, 3)); +## PySpark 3.5.5 Result: {'size(array(1, 2, 3))': 3} + +# Basic array size tests +query I +SELECT size(make_array(1, 2, 3)); +---- +3 + +query I +SELECT size(make_array(1, 2, 3, 4, 5)); +---- +5 + +query I +SELECT size(make_array(1)); +---- +1 + +# Empty array +query I +SELECT size(arrow_cast(make_array(), 'List(Int32)')); +---- +0 + +# Nested arrays +query I +SELECT size(make_array(make_array(1, 2), make_array(3, 4, 5))); +---- +2 + +# Array with NULL elements (size counts elements including NULLs) +query I +SELECT size(make_array(1, NULL, 3)); +---- +3 + +# NULL array returns -1 (Spark behavior) +query I +SELECT size(NULL::int[]); +---- +-1 + +# Map size tests +query I +SELECT size(map(make_array('a', 'b', 'c'), make_array(1, 2, 3))); +---- +3 + +query I +SELECT size(map(make_array('a'), make_array(1))); +---- +1 + +# Empty map +query I +SELECT size(map(arrow_cast(make_array(), 'List(Utf8)'), arrow_cast(make_array(), 'List(Int32)'))); +---- +0 + +# Map with multiple entries +query I +SELECT size(map(make_array('x', 'y', 'z', 'w'), make_array(10, 20, 30, 40))); +---- +4 + +# String array +query I +SELECT size(make_array('hello', 'world')); +---- +2 + +# Boolean array +query I +SELECT size(make_array(true, false, true)); +---- +3 + +# Float array +query I +SELECT size(make_array(1.5, 2.5, 3.5, 4.5)); +---- +4 + +# LargeList tests +query I +SELECT size(arrow_cast(make_array(1, 2, 3), 'LargeList(Int32)')); +---- +3 + +query I +SELECT size(arrow_cast(make_array(1, 2, 3, 4, 5), 'LargeList(Int64)')); +---- +5 + +# FixedSizeList tests +query I +SELECT size(arrow_cast(make_array(1, 2, 3), 'FixedSizeList(3, Int32)')); +---- +3 + Review Comment: @Jefffrey thanks for your suggestion. I added two more tests and reorganized the tests order. PTAL when you have a chance. Thanks!. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
