Nachiket-Roy commented on code in PR #19633:
URL: https://github.com/apache/datafusion/pull/19633#discussion_r2700758268
##########
datafusion/catalog/src/table.rs:
##########
@@ -353,6 +353,14 @@ pub trait TableProvider: Debug + Sync + Send {
) -> Result<Arc<dyn ExecutionPlan>> {
not_impl_err!("UPDATE not supported for {} table", self.table_type())
}
+
+ /// Remove all rows from the table.
+ ///
+ /// Returns an [`ExecutionPlan`] producing a single row with `count`
(UInt64),
+ /// representing the number of rows removed.
Review Comment:
I attempted tightening the test using TestMemoryExec to materialize a
{count: UInt64} row.
However, this triggers a physical optimizer rewrite, which calls
`with_new_children` on `TestMemoryExec`, and that method is not implemented:
```
TestMemoryExec::with_new_children not implemented
```
Ethan pointed this out as well. Because the optimizer rewrites the plan, the
test can’t reliably validate the actual output row. This follows the same
pattern as the existing DELETE/UPDATE tests, which validate the schema and hook
invocation rather than the concrete row content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
