Jefffrey commented on code in PR #19633:
URL: https://github.com/apache/datafusion/pull/19633#discussion_r2701158565
##########
datafusion/catalog/src/table.rs:
##########
@@ -353,6 +353,14 @@ pub trait TableProvider: Debug + Sync + Send {
) -> Result<Arc<dyn ExecutionPlan>> {
not_impl_err!("UPDATE not supported for {} table", self.table_type())
}
+
+ /// Remove all rows from the table.
+ ///
+ /// Returns an [`ExecutionPlan`] producing a single row with `count`
(UInt64),
+ /// representing the number of rows removed.
Review Comment:
I don't mean as a test within datafusion; I mean, what stops an implementer
of this function from just returning something other than a UInt64 row? Are
there any checks within datafusions planners that it returns the correct
type/result, otherwise this seems more like a guideline if we can't enforce it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
