Jefffrey commented on code in PR #19633:
URL: https://github.com/apache/datafusion/pull/19633#discussion_r2701161206
##########
datafusion/sql/src/statement.rs:
##########
@@ -1390,6 +1390,56 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
exec_err!("Function name not provided")
}
}
+ Statement::Truncate(ast::Truncate {
+ table_names,
+ partitions,
+ identity,
+ cascade,
+ on_cluster,
+ table,
+ }) => {
+ let _ = table; // explicitly handled to satisfy full
destructuring
Review Comment:
This comment isn't informative; we should be explaining in the context of
the SQL syntax, not in terms of code readability. Why is is alright for us to
ignore this parameter in terms of the SQL syntax we accept?
##########
datafusion/sql/src/statement.rs:
##########
@@ -1390,6 +1390,56 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
exec_err!("Function name not provided")
}
}
+ Statement::Truncate(ast::Truncate {
+ table_names,
+ partitions,
+ identity,
+ cascade,
+ on_cluster,
+ table,
+ }) => {
+ let _ = table; // explicitly handled to satisfy full
destructuring
Review Comment:
This comment isn't informative; we should be explaining in the context of
the SQL syntax, not in terms of code structure. Why is is alright for us to
ignore this parameter in terms of the SQL syntax we accept?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
