kumarUjjawal commented on code in PR #19739:
URL: https://github.com/apache/datafusion/pull/19739#discussion_r2709565045
##########
datafusion/substrait/src/logical_plan/producer/expr/mod.rs:
##########
@@ -139,16 +139,16 @@ pub fn to_substrait_rex(
}
Expr::WindowFunction(expr) => producer.handle_window_function(expr,
schema),
Expr::InList(expr) => producer.handle_in_list(expr, schema),
- Expr::Exists(expr) => not_impl_err!("Cannot convert {expr:?} to
Substrait"),
+ Expr::Exists(expr) => producer.handle_exists(expr, schema),
Expr::InSubquery(expr) => producer.handle_in_subquery(expr, schema),
- Expr::ScalarSubquery(expr) => {
- not_impl_err!("Cannot convert {expr:?} to Substrait")
- }
+ Expr::ScalarSubquery(expr) => producer.handle_scalar_subquery(expr,
schema),
#[expect(deprecated)]
Expr::Wildcard { .. } => not_impl_err!("Cannot convert {expr:?} to
Substrait"),
Expr::GroupingSet(expr) => not_impl_err!("Cannot convert {expr:?} to
Substrait"),
Expr::Placeholder(expr) => not_impl_err!("Cannot convert {expr:?} to
Substrait"),
Expr::OuterReferenceColumn(_, _) => {
+ // OuterReferenceColumn requires tracking outer query schema
context for correlated
Review Comment:
Yeah for the remaining issues I intend to open follow up PRs. My goal is to
resolve all the issue related to substrait in the next few weeks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
