benbellick commented on code in PR #19739:
URL: https://github.com/apache/datafusion/pull/19739#discussion_r2714688563
##########
datafusion/substrait/src/logical_plan/producer/substrait_producer.rs:
##########
@@ -361,6 +364,31 @@ pub trait SubstraitProducer: Send + Sync + Sized {
) -> datafusion::common::Result<Expression> {
from_in_subquery(self, in_subquery, schema)
}
+
+ fn handle_scalar_subquery(
+ &mut self,
+ subquery: &Subquery,
+ schema: &DFSchemaRef,
+ ) -> datafusion::common::Result<Expression> {
+ from_scalar_subquery(self, subquery, schema)
+ }
+
+ fn handle_exists(
+ &mut self,
+ exists: &Exists,
+ schema: &DFSchemaRef,
+ ) -> datafusion::common::Result<Expression> {
+ from_exists(self, exists, schema)
+ }
+
+ fn handle_outer_reference_column(
Review Comment:
Am I correct that this is dead code? Maybe was intended to be added to the
match in `datafusion/substrait/src/logical_plan/producer/expr/mod.rs`, but is
now being left for later.
##########
datafusion/substrait/src/logical_plan/producer/expr/field_reference.rs:
##########
@@ -76,6 +76,22 @@ pub(crate) fn try_to_substrait_field_reference(
}
}
+/// Convert an outer reference column to a Substrait field reference.
+/// Outer reference columns reference columns from an outer query scope in
correlated subqueries.
+/// We convert them the same way as regular columns since the subquery plan
will be
+/// reconstructed with the proper schema context during consumption.
+pub fn from_outer_reference_column(
Review Comment:
Is this also deadcode (once the single deadcode caller is deleted)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
