ywkaras commented on a change in pull request #6720:
URL: https://github.com/apache/trafficserver/pull/6720#discussion_r419789434
##########
File path: mgmt/MgmtDefs.h
##########
@@ -72,71 +73,78 @@ struct MgmtConverter {
* This is passed a @c void* which is a pointer to the member in the
configuration instance.
* This function must return a @c MgmtInt converted from that value.
*/
- MgmtInt (*load_int)(const void *) = nullptr;
+ MgmtInt (*load_int)(const TSHttpTxn txnp, const void *) = nullptr;
Review comment:
In order to use, you would need to reinterpret cast it to HttpSM * no?
It seems like it would be better to have the parameter type be HttpSM *. I
think rule of thumb is that apidefs.h and ts.h should only be included in
plugins and the implementation files for the TS API. Unfortunately, I think
you will probably not be able to use const HttpSM *, I don't think the HttpSM
class is const correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
