SolidWallOfCode commented on a change in pull request #6720:
URL: https://github.com/apache/trafficserver/pull/6720#discussion_r420128941
##########
File path: mgmt/MgmtDefs.h
##########
@@ -72,71 +73,78 @@ struct MgmtConverter {
* This is passed a @c void* which is a pointer to the member in the
configuration instance.
* This function must return a @c MgmtInt converted from that value.
*/
- MgmtInt (*load_int)(const void *) = nullptr;
+ MgmtInt (*load_int)(const TSHttpTxn txnp, const void *) = nullptr;
Review comment:
Walt is basically correct. Originally there was just "ts.h". I split it
into "ts.h" and "apidefs.h" precisely so "apidefs.h" could be included in core
code. Core code should never include "ts.h". Core code should use C Plugin API
types only in API functions expected to be called from a plugin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
