SolidWallOfCode commented on a change in pull request #6720:
URL: https://github.com/apache/trafficserver/pull/6720#discussion_r420130911
##########
File path: proxy/http/HttpConnectionCount.cc
##########
@@ -38,17 +39,27 @@ OutboundConnTrack::Imp OutboundConnTrack::_imp;
OutboundConnTrack::GlobalConfig *OutboundConnTrack::_global_config{nullptr};
const MgmtConverter OutboundConnTrack::MAX_CONV(
- [](const void *data) -> MgmtInt { return
static_cast<MgmtInt>(*static_cast<const decltype(TxnConfig::max) *>(data)); },
- [](void *data, MgmtInt i) -> void { *static_cast<decltype(TxnConfig::max)
*>(data) = static_cast<decltype(TxnConfig::max)>(i); });
+ [](const TSHttpTxn txnp, const void *data) -> MgmtInt {
Review comment:
The signature should be `const HttpSM*, const void * data)`. Drop the
name of the unused parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
