maskit commented on a change in pull request #6910:
URL: https://github.com/apache/trafficserver/pull/6910#discussion_r442578153
##########
File path: iocore/net/SSLNetVConnection.cc
##########
@@ -1260,9 +1260,9 @@ SSLNetVConnection::sslServerHandShakeEvent(int &err)
this->reenable(&read.vio);
this->read.triggered = 1;
}
- }
+ } else
Review comment:
Is this really ok? I didn't checked where `ssl_error` is changed, but it
seems like `ssl_error` can be `SSL_ERROR_WANT_READ` at least. I guess we should
update `err` in the case at minimum?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
