oknet commented on a change in pull request #6910:
URL: https://github.com/apache/trafficserver/pull/6910#discussion_r442714628
##########
File path: iocore/net/SSLNetVConnection.cc
##########
@@ -1238,12 +1238,12 @@ SSLNetVConnection::sslServerHandShakeEvent(int &err)
if (SSL_get_all_async_fds(ssl, &waitfd, &numfds) && numfds > 0) {
Review comment:
Reference:
https://www.openssl.org/docs/man1.1.0/man3/SSL_waiting_for_async.html
`The number of file descriptors returned is stored in *numfds and the file
descriptors themselves are in *fds. The fds parameter may be NULL in which case
no file descriptors are returned but *numfds is still populated. It is the
callers responsibility to ensure sufficient memory is allocated at *fds so
typically this function is called twice (once with a NULL fds parameter and
once without).`
Memory leaks here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
