oknet commented on a change in pull request #6910:
URL: https://github.com/apache/trafficserver/pull/6910#discussion_r442755331
##########
File path: iocore/net/SSLNetVConnection.cc
##########
@@ -1238,12 +1238,12 @@ SSLNetVConnection::sslServerHandShakeEvent(int &err)
if (SSL_get_all_async_fds(ssl, &waitfd, &numfds) && numfds > 0) {
// Temporarily disable regular net
read_disable(nh, this);
+ write_disable(nh, this);
this->ep.stop(); // Modify used in read_disable doesn't work for edge
triggered epol
// Have to have the read NetState enabled because we are using it for
the signal vc
- read.enabled = true;
- write_disable(nh, this);
+ read.enabled = true;
PollDescriptor *pd = get_PollDescriptor(this_ethread());
- this->ep.start(pd, waitfd, this, EVENTIO_READ);
+ this->ep.start(pd, waitfd, static_cast<NetEvent *>(this), EVENTIO_READ);
this->ep.type = EVENTIO_READWRITE_VC;
Review comment:
IMO, replace these lines (L1240-1244) with `read.triggered = false` and
`write.triggered = false` is more suitable here. Also the L1252 to L1258 can be
deleted.
The lines L1245-L1247:
The `waitfd` is differ to `con.fd`, It is better to create a new object and
a new type of EventIO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
