masaori335 commented on pull request #6889: URL: https://github.com/apache/trafficserver/pull/6889#issuecomment-650866127
> e). setting this on do_io_write() in many places > > Replacing nullptr for the continuation with this. Trying to minimize the places where a netvc can close without having a continuation to signal back to. Avoiding the opportunity for having a stale client _vc pointer associated with the Client Session. > It looks like this is assuming the netvc try writing after these `do_io_write()` calls. I'm fine with replacing nullptr, but I doubt something accidentally re-enable (or doesn't cancel) writing of the netvc. > g). call _vc->do_io_close() from Http2ClientSession::do_io_close() for consistency with b). > > We don't actually have this change internally, but it did seem reasonable to have the same strategy for shutting down the netvc vs the session for Http/1 and Http/2. > I noticed this is part of b). #6364 removed the `client_vc->do_io_close();` from `Http2ClientSession::do_io_close()` too. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
