shinrich commented on pull request #6889: URL: https://github.com/apache/trafficserver/pull/6889#issuecomment-648186938
d). set EHTTP_ERROR on do_io_close() In the error or immediate close cases for Http1ClientSession force through the close. Do not got through the half-close state. Also discussed in PR #6732 e). setting this on do_io_write() in many places Replacing nullptr for the continuation with this. Trying to minimize the places where a netvc can close without having a continuation to signal back to. Avoiding the opportunity for having a stale client _vc pointer associated with the Client Session. f). call ua_txn->do_io_close() on HttpSM::tunnel_handler_post_ua() An attempt to simplify error processing. Rather than having the client netvc linger on generating errors and timeouts, go ahead and shutdown the client netvc in the error case. g). call _vc->do_io_close() from Http2ClientSession::do_io_close() for consistency with b). We don't actually have this change internally, but it did seem reasonable to have the same strategy for shutting down the netvc vs the session for Http/1 and Http/2. h). checking write_vio.nbytes on Http2Stream Not sure why that came back in. Our internal build is not currently running with those changes. I will update my test ASF 9.0.x plus minimal changes build to remove those changes, and update this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
