masaori335 commented on pull request #6889: URL: https://github.com/apache/trafficserver/pull/6889#issuecomment-647839935
Let me clarify what we have so far. 1). #6364 tried to fix the misordering of SSN/TXN Start/Close hooks. However, it introduced crashes, because it removed `client_vc->do_io_close()` from `Http1ClientSession::do_io_close()`. 2). The first approach for 1). was #6469. However, it didn't work well. 3). The second approach is this PR. It looks like this PR includes below changes a). revert #6469 b). restore `_vc->do_io_close()` which made by #6364 c). fix AuTest (the order of SSN_CLOSE and VC_CLOSE) which is introduced by b). d). set `EHTTP_ERROR` on `do_io_close()` e). setting `this` on `do_io_write()` in many places f). call `ua_txn->do_io_close()` on `HttpSM::tunnel_handler_post_ua()` g). call `_vc->do_io_close()` from `Http2ClientSession::do_io_close()` for consistency with b). h). checking `write_vio.nbytes` on Http2Stream Changes from a). to c). looks reasonable for me. I might simplify issues too much, however, I don't get why other changes ( from d). to h). ) are necessary and why all these changes need to be combined in one commit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
