ywkaras commented on a change in pull request #7079:
URL: https://github.com/apache/trafficserver/pull/7079#discussion_r464763413
##########
File path: iocore/net/quic/QUICTransportParameters.h
##########
@@ -61,7 +61,7 @@ class QUICTransportParameterId
}
bool
- operator==(uint16_t &x) const
+ operator==(const uint16_t &x) const
Review comment:
Nitpick: you could simply pass by value here and it would inline to the
same asm code: https://godbolt.org/z/9za8xz .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
