ywkaras commented on a change in pull request #7079:
URL: https://github.com/apache/trafficserver/pull/7079#discussion_r464773075
##########
File path: iocore/net/quic/QUICFrame.h
##########
@@ -234,7 +234,7 @@ class QUICAckFrame : public QUICFrame
size_t size() const;
Ptr<IOBufferBlock> to_io_buffer_block(size_t limit) const;
uint64_t first_ack_block() const;
- void add_ack_block(const AckBlock block);
+ void add_ack_block(const AckBlock &block);
Review comment:
Yes you can make an argument that, except in rare cases, it's
overoptimizing to pass class types by value. It's future safe if new member
variables get added to the class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
