maskit commented on a change in pull request #7079:
URL: https://github.com/apache/trafficserver/pull/7079#discussion_r464773519
##########
File path: iocore/net/quic/qlog/QLog.h
##########
@@ -46,9 +46,13 @@ class Trace
VantagePointType flow = VantagePointType::unknown;
};
- Trace(std::string odcid, std::string title = "", std::string desc = "") :
_reference_time(Thread::get_hrtime()), _odcid(odcid) {}
+ Trace(const std::string &odcid, const std::string &title = "", const
std::string &desc = "")
Review comment:
I appreciate the feedback but it doesn't seem to be related to
const-ify. Please file an issue or make a PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
