ywkaras commented on a change in pull request #7262:
URL: https://github.com/apache/trafficserver/pull/7262#discussion_r512118597
##########
File path: tests/gold_tests/pluginTest/tsapi/tsapi.test.py
##########
@@ -71,7 +71,15 @@
tr.Processes.Default.StartBefore(Test.Processes.ts)
#
tr.Processes.Default.Command = (
- 'curl --verbose --ipv4 --header "Host: mYhOsT.teSt:{0}"
hTtP://loCalhOst:{1}/'.format(server.Variables.Port, ts.Variables.port)
+ r'printf "GET / HTTP/1.1\r\nHost: mYhOsT.teSt:{0}\r\n\r\n" | nc localhost
{1}'.format(
Review comment:
OK I think I see what you mean now:
```
$ curl --verbose http://httpbin.org/ip 2>&1 | grep '^> '
> GET /ip HTTP/1.1
> Host: httpbin.org
> User-Agent: curl/7.66.0-DEV
> Accept: */*
>
$ curl --verbose -x httpbin.org:80 http://httpbin.org/ip 2>&1 | grep '^> '
> GET http://httpbin.org/ip HTTP/1.1
> Host: httpbin.org
> User-Agent: curl/7.66.0-DEV
> Accept: */*
> Proxy-Connection: Keep-Alive
>
$
```
But to me this makes the test harder rather than easier to understand and
maintain. Notice that curl inserts several headers that are not relevant to
the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
