maskit commented on a change in pull request #7262:
URL: https://github.com/apache/trafficserver/pull/7262#discussion_r512362186



##########
File path: tests/gold_tests/pluginTest/tsapi/tsapi.test.py
##########
@@ -71,7 +71,15 @@
 tr.Processes.Default.StartBefore(Test.Processes.ts)
 #
 tr.Processes.Default.Command = (
-    'curl --verbose --ipv4 --header "Host: mYhOsT.teSt:{0}" 
hTtP://loCalhOst:{1}/'.format(server.Variables.Port, ts.Variables.port)
+    r'printf "GET / HTTP/1.1\r\nHost: mYhOsT.teSt:{0}\r\n\r\n" | nc localhost 
{1}'.format(

Review comment:
       > Notice that curl inserts several headers that are not relevant to the 
test.
   
   I think they are relevant because they may change ATS's behavior. I guess 
major clients send Proxy-Client when they use absolute form, so testing the 
behavior without the header may be missing the point. And we can easily make 
natural requests by using curl. I don't think I can always do it manually.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to