dbhat commented on a change in pull request #7516:
URL: https://github.com/apache/trafficserver/pull/7516#discussion_r596148150
##########
File path: plugins/header_rewrite/parser.cc
##########
@@ -244,6 +244,14 @@ Parser::cond_is_hook(TSHttpHookID &hook) const
hook = TS_REMAP_PSEUDO_HOOK;
return true;
}
+ if ("TXN_START_HOOK" == _op) {
Review comment:
Right now we include all hooks in
[TSHttpHookID](https://github.com/apache/trafficserver/blob/d4fc16f64d3104d3682d496e47f2a53511fa77e0/include/ts/apidefs.h.in#L266)
without filtering for ones that are applicable:
https://github.com/apache/trafficserver/blob/d4fc16f64d3104d3682d496e47f2a53511fa77e0/plugins/header_rewrite/header_rewrite.cc#L451
We do not have errors/warnings for non-applicable hooks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
