maskit commented on a change in pull request #7516:
URL: https://github.com/apache/trafficserver/pull/7516#discussion_r596633578
##########
File path: plugins/header_rewrite/resources.cc
##########
@@ -99,6 +104,24 @@ Resources::gather(const ResourceIDs ids, TSHttpHookID hook)
}
break;
+ case TS_HTTP_TXN_START_HOOK:
+ // Get TCP Info at transaction start
+ if (client_bufp && client_hdr_loc) {
+ TSDebug(PLUGIN_NAME, "\tAdding TXN Start header buffers");
+ bufp = client_bufp;
+ hdr_loc = client_hdr_loc;
+ }
+ break;
+
+ case TS_HTTP_TXN_CLOSE_HOOK:
+ // Get TCP Info at transaction close
+ if (client_bufp && client_hdr_loc) {
+ TSDebug(PLUGIN_NAME, "\tAdding TXN Close header buffers");
+ bufp = client_bufp;
Review comment:
I'd expect headers added on TS_HTTP_TXN_CLOSE_HOOK are available in
client *response* header. This code seems like to add headers to client
*request* headers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
