maskit commented on a change in pull request #7516:
URL: https://github.com/apache/trafficserver/pull/7516#discussion_r596615696
##########
File path: plugins/header_rewrite/resources.cc
##########
@@ -99,6 +104,24 @@ Resources::gather(const ResourceIDs ids, TSHttpHookID hook)
}
break;
+ case TS_HTTP_TXN_START_HOOK:
+ // Get TCP Info at transaction start
+ if (client_bufp && client_hdr_loc) {
Review comment:
If I'm reading the code correctly, this condition would never be true
because request header has not been read on `TS_HTTP_TXN_START_HOOK` yet.
https://docs.trafficserver.apache.org/en/9.0.x/developer-guide/plugins/hooks-and-transactions/index.en.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
