maskit commented on a change in pull request #7714:
URL: https://github.com/apache/trafficserver/pull/7714#discussion_r616372769



##########
File path: iocore/net/SSLNetVConnection.cc
##########
@@ -621,7 +621,7 @@ SSLNetVConnection::net_read_io(NetHandler *nh, EThread 
*lthread)
           Debug("ssl", "ssl handshake for vc %p, expired, release the 
connection", this);
           read.triggered = 0;
           nh->read_ready_list.remove(this);
-          readSignalError(nh, VC_EVENT_EOS);
+          readSignalError(nh, EPIPE);

Review comment:
       I don't think EOS is correct, but EPIPE doesn't seem appropriate as 
well. I'd use ETIMEDOUT if we can change it to any error code and want to 
choose one from standard ESOMETHING error codes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to