maskit commented on a change in pull request #7714:
URL: https://github.com/apache/trafficserver/pull/7714#discussion_r620805415
##########
File path: iocore/net/SSLNetVConnection.cc
##########
@@ -736,7 +736,7 @@ SSLNetVConnection::net_read_io(NetHandler *nh, EThread
*lthread)
break;
case SSL_READ_ERROR:
this->read.triggered = 0;
- readSignalError(nh, static_cast<int>(r));
+ readSignalError(nh, (errno) ? errno : -ENET_SSL_FAILED);
Review comment:
> Would you like me to save the errno value directly after the all to
ssl_read_from_net?
Not sure if it has to be all, but yes. A problem is that `errno` could be
changed if I added some code between `ssl_read_from_net` (or `readSignalError`)
and this line. If that's another I/O related code then it may be ok, but it
might be something for completely different things (e.g. debugging, logging,
etc).
So the current code is fine. It just looks fragile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
