maskit commented on a change in pull request #7714:
URL: https://github.com/apache/trafficserver/pull/7714#discussion_r617131821
##########
File path: iocore/net/SSLNetVConnection.cc
##########
@@ -736,7 +736,7 @@ SSLNetVConnection::net_read_io(NetHandler *nh, EThread
*lthread)
break;
case SSL_READ_ERROR:
this->read.triggered = 0;
- readSignalError(nh, static_cast<int>(r));
+ readSignalError(nh, (errno) ? errno : -ENET_SSL_FAILED);
Review comment:
What abut this one? I guess it's checking errno set by
`ssl_read_from_net`, but it can be changed in `readSignalAndUpdate`. I'm not
opposed to propagating errno but we should secure the value right after calling
a function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
