maskit commented on code in PR #8963:
URL: https://github.com/apache/trafficserver/pull/8963#discussion_r921938919
##########
proxy/http2/Http2ConnectionState.cc:
##########
@@ -1278,8 +1333,115 @@ Http2ConnectionState::state_closed(int event, void
*edata)
return 0;
}
+bool
+Http2ConnectionState::is_peer_concurrent_stream_ub() const
+{
+ return client_streams_in_count >=
(peer_settings.get(HTTP2_SETTINGS_MAX_CONCURRENT_STREAMS)) * 0.9;
+}
+
+bool
+Http2ConnectionState::is_peer_concurrent_stream_lb() const
+{
+ return client_streams_in_count <=
(peer_settings.get(HTTP2_SETTINGS_MAX_CONCURRENT_STREAMS)) / 2;
+}
+
+void
+Http2ConnectionState::set_stream_id(Http2Stream *stream)
+{
+ if (stream->get_transaction_id() < 0) {
+ Http2StreamId stream_id = (latest_streamid_in == 0) ? 3 :
latest_streamid_in + 2;
+ stream->set_transaction_id(stream_id);
+ latest_streamid_in = stream_id;
+ }
+}
+
+Http2Stream *
+Http2ConnectionState::create_initiating_stream(bool client_streamid,
Http2Error &error)
Review Comment:
It seems like `client_streamid` is always `true`, and `error` is not used on
the caller side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
