maskit commented on code in PR #8963:
URL: https://github.com/apache/trafficserver/pull/8963#discussion_r921905654
##########
proxy/ProxySession.cc:
##########
@@ -313,3 +315,21 @@ ProxySession::support_sni() const
{
return _vc ? _vc->support_sni() : false;
}
+
+PoolableSession *
+ProxySession::protocol_creation(NetVConnection *netvc)
+{
+ // Figure out what protocol was negotiated
+ int proto_index = SessionProtocolNameRegistry::INVALID;
+ SSLNetVConnection *sslnetvc = dynamic_cast<SSLNetVConnection *>(netvc);
Review Comment:
Actually, I don't see any reason to receive a NetVC here. Just a protocol id
is enough. Let's deal with NetVC on HttpSM side.
How about this? I want function names to have verbs.
```
PoolableSession *
ProxySession::create_outbound_sesion(int protocol_id) {
auto iter = ProtocolSessionCreateMap.find(protocol_id);
ink_release_assert(iter != ProtocolSessionCreateMap.end());
return iter->second();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
