maskit commented on code in PR #8963: URL: https://github.com/apache/trafficserver/pull/8963#discussion_r921855305
########## proxy/http/HttpProxyServerMain.cc: ########## @@ -50,6 +50,9 @@ HttpSessionAccept *plugin_http_accept = nullptr; HttpSessionAccept *plugin_http_transparent_accept = nullptr; +extern std::function<PoolableSession *()> Create_h1_server_session; Review Comment: Why don't you make the first lowercase? These are not types but variables. ########## proxy/http/HttpProxyServerMain.cc: ########## @@ -50,6 +50,9 @@ HttpSessionAccept *plugin_http_accept = nullptr; HttpSessionAccept *plugin_http_transparent_accept = nullptr; +extern std::function<PoolableSession *()> Create_h1_server_session; Review Comment: Why don't you make the first letters lowercase? These are not types but variables. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
