maskit commented on code in PR #9767:
URL: https://github.com/apache/trafficserver/pull/9767#discussion_r1239023425
##########
iocore/net/TLSSNISupport.cc:
##########
@@ -64,8 +67,12 @@ TLSSNISupport::perform_sni_action()
}
SNIConfig::scoped_config params;
- if (const auto &actions = params->get({servername,
std::strlen(servername)}); !actions.first) {
- Debug("ssl_sni", "%s not available in the map", servername);
+ // should always work in this context of SSL action callbacks
+ SSLNetVConnection *ssl_vc{dynamic_cast<SSLNetVConnection *>(this)};
Review Comment:
The existing dynamic_casts were written before QUIC, and we need to fix
them. New code should try not to introduce a new one.
Here are two options but there may be better ways.
- Get a port number from SSL object
- Add a protected virtual function, which returns a port number, to
SNISupport
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
