maskit commented on code in PR #9767:
URL: https://github.com/apache/trafficserver/pull/9767#discussion_r1240016287
##########
iocore/net/TLSSNISupport.cc:
##########
@@ -64,8 +67,12 @@ TLSSNISupport::perform_sni_action()
}
SNIConfig::scoped_config params;
- if (const auto &actions = params->get({servername,
std::strlen(servername)}); !actions.first) {
- Debug("ssl_sni", "%s not available in the map", servername);
+ // should always work in this context of SSL action callbacks
+ SSLNetVConnection *ssl_vc{dynamic_cast<SSLNetVConnection *>(this)};
Review Comment:
It doesn't look like a right direction to me. What design change are you
planning?
With this change for port number filtering, although port number is not
directly related to SNI, port number becomes essential to support SNI (or more
specifically, SNIAction) on a `NetVConnectoin` implementation. I'd require a
`NetVConnection` implementation to have the capability of providing the local
port number by adding `virtual int _get_local_port() = 0` to `TLSSNISupport`.
If one cannot fulfill the requirement, the implementation can't say it supports
"SNI".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
