maskit commented on code in PR #9767:
URL: https://github.com/apache/trafficserver/pull/9767#discussion_r1240353332
##########
iocore/net/TLSSNISupport.cc:
##########
@@ -64,8 +67,12 @@ TLSSNISupport::perform_sni_action()
}
SNIConfig::scoped_config params;
- if (const auto &actions = params->get({servername,
std::strlen(servername)}); !actions.first) {
- Debug("ssl_sni", "%s not available in the map", servername);
+ // should always work in this context of SSL action callbacks
+ SSLNetVConnection *ssl_vc{dynamic_cast<SSLNetVConnection *>(this)};
Review Comment:
It's fine to have a local port number. I'm just talking about how to access
it.
`NetVConnection` can keep current `get_local_port()`, and I'm suggesting a
protected new function `_get_local_prot()` so `TLSSNISupport` can access it
without depending on any `NetVConnection`. The new function is an interface
between `TLSSNISupport` and something that supports `TLSSNISupport`.
`TLSSNISupport` itself doesn't need `NetVConnection` (i.e. `TLSSNISupport`
doesn't need to transfer data over network).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
