maskit commented on PR #9482: URL: https://github.com/apache/trafficserver/pull/9482#issuecomment-1608492690
> It avoids having to pass an SERVICE enum value to get_service() and then cast to the corresponding pointer type (error prone and verbose). I think this was addressed by having `NetConnectinoService`, which James suggested. > It avoids the need for a _services[] array in every instance of NetVConnection. This might increase cache hits and thus improve performance. Maybe? I'm not sure how much it helps. Your `get_service` has a conditional branch and an addition. Need some numbers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
